Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48368 )
Change subject: scons,test: Don't -Wall or -Werror for googletest libraries.
......................................................................
scons,test: Don't -Wall or -Werror for googletest libraries.
These libraries come from elsewhere, and so there's no reason to worry
about warnings. We can't fix them even if they crop up. Also, set
CCFLAGS to avoid having a mixture of gem5 flags and googletest flags.
Change-Id: I19b07747a43cebb263ae1546c75631cff1f13132
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48368
Maintainer: Gabe Black <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
---
M ext/googletest/SConscript
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, but someone else must approve
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/ext/googletest/SConscript b/ext/googletest/SConscript
index e5241d6..5a4b691 100644
--- a/ext/googletest/SConscript
+++ b/ext/googletest/SConscript
@@ -43,9 +43,8 @@
main.Append(CPPPATH=[gtest_include, gmock_include])
main.Append(LIBPATH=[build])
-env = main.Clone(CPPFLAGS=['-g', '-Wall', '-Wextra', '-pthread',
- '-Wno-undef', '-isystem', str(gtest_include),
- '-isystem', str(gmock_include)])
+env = main.Clone(CCFLAGS=['-g', '-pthread', '-Wno-undef', '-isystem',
+ str(gtest_include), '-isystem',
str(gmock_include)])
env.Append(CPPPATH=[gtest_base, gmock_base])
gtest_all = env.Object(gtest_src.File('gtest-all.cc'))
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48368
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I19b07747a43cebb263ae1546c75631cff1f13132
Gerrit-Change-Number: 48368
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
