Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/48645 )

Change subject: scons: Add the "print_suppressions=0" option to the LSAN warning.
......................................................................

scons: Add the "print_suppressions=0" option to the LSAN warning.

This is part of what SCons uses internally, and is probably what someone
using LSAN_OPTIONS would want to use externally too.

Change-Id: I413c680829e0edab76598122637e3236c35e8209
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48645
Maintainer: Bobby R. Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
---
M SConstruct
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/SConstruct b/SConstruct
index d9d2db3..617c7b4 100755
--- a/SConstruct
+++ b/SConstruct
@@ -408,13 +408,13 @@
     sanitizers.append('address')
     suppressions_file = Dir('util').File('lsan-suppressions').get_abspath()
     suppressions_opt = 'suppressions=%s' % suppressions_file
-    main['ENV']['LSAN_OPTIONS'] = ':'.join([suppressions_opt,
-                                            'print_suppressions=0'])
+ suppressions_opts = ':'.join([suppressions_opt, 'print_suppressions=0'])
+    main['ENV']['LSAN_OPTIONS'] = suppressions_opts
     print()
     warning('To suppress false positive leaks, set the LSAN_OPTIONS '
             'environment variable to "%s" when running gem5' %
-            suppressions_opt)
-    warning('LSAN_OPTIONS=%s' % suppressions_opt)
+            suppressions_opts)
+    warning('LSAN_OPTIONS=%s' % suppressions_opts)
     print()
 if sanitizers:
     sanitizers = ','.join(sanitizers)



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48645
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I413c680829e0edab76598122637e3236c35e8209
Gerrit-Change-Number: 48645
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to