Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48926 )
Change subject: dev: Fix style in i8254xGBE.cc.
......................................................................
dev: Fix style in i8254xGBE.cc.
Add missing spaces, remove excess spaces.
Change-Id: I9841a80172d3f1edfe68d9d4571535fe253f465e
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48926
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/dev/net/i8254xGBe.cc
1 file changed, 30 insertions(+), 29 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/net/i8254xGBe.cc b/src/dev/net/i8254xGBe.cc
index 7e9549a..1bfa85f 100644
--- a/src/dev/net/i8254xGBe.cc
+++ b/src/dev/net/i8254xGBe.cc
@@ -106,11 +106,11 @@
eeOpcode = 0;
// clear all 64 16 bit words of the eeprom
- memset(&flash, 0, EEPROM_SIZE*2);
+ memset(&flash, 0, EEPROM_SIZE * 2);
// Set the MAC address
memcpy(flash, p.hardware_address.bytes(), ETH_ADDR_LEN);
- for (int x = 0; x < ETH_ADDR_LEN/2; x++)
+ for (int x = 0; x < ETH_ADDR_LEN / 2; x++)
flash[x] = htobe(flash[x]);
uint16_t csum = 0;
@@ -119,7 +119,7 @@
// Magic happy checksum value
- flash[EEPROM_SIZE-1] = htobe((uint16_t)(EEPROM_CSUM - csum));
+ flash[EEPROM_SIZE - 1] = htobe((uint16_t)(EEPROM_CSUM - csum));
// Store the MAC address as queue ID
macAddr = p.hardware_address;
@@ -341,9 +341,9 @@
pkt->setLE<uint32_t>(regs.sw_fw_sync);
break;
default:
- if (!IN_RANGE(daddr, REG_VFTA, VLAN_FILTER_TABLE_SIZE*4) &&
- !IN_RANGE(daddr, REG_RAL, RCV_ADDRESS_TABLE_SIZE*8) &&
- !IN_RANGE(daddr, REG_MTA, MULTICAST_TABLE_SIZE*4) &&
+ if (!IN_RANGE(daddr, REG_VFTA, VLAN_FILTER_TABLE_SIZE * 4) &&
+ !IN_RANGE(daddr, REG_RAL, RCV_ADDRESS_TABLE_SIZE * 8) &&
+ !IN_RANGE(daddr, REG_MTA, MULTICAST_TABLE_SIZE * 4) &&
!IN_RANGE(daddr, REG_CRCERRS, STATS_REGS_SIZE))
panic("Read request to unknown register number: %#x\n", daddr);
else
@@ -408,11 +408,12 @@
eeAddr = eeAddr << 1 | regs.eecd.din();
eeAddrBits++;
} else if (eeDataBits < 16 && eeOpcode ==
EEPROM_READ_OPCODE_SPI) {
- assert(eeAddr>>1 < EEPROM_SIZE);
+ assert(eeAddr >> 1 < EEPROM_SIZE);
DPRINTF(EthernetEEPROM, "EEPROM bit read: %d word: %#X\n",
- flash[eeAddr>>1] >> eeDataBits & 0x1,
- flash[eeAddr>>1]);
- regs.eecd.dout((flash[eeAddr>>1] >> (15-eeDataBits)) &
0x1);
+ flash[eeAddr >> 1] >> eeDataBits & 0x1,
+ flash[eeAddr >> 1]);
+ regs.eecd.dout(
+ (flash[eeAddr >> 1] >> (15 - eeDataBits)) & 0x1);
eeDataBits++;
} else if (eeDataBits < 8 && eeOpcode ==
EEPROM_RDSR_OPCODE_SPI) {
regs.eecd.dout(0);
@@ -435,7 +436,7 @@
DPRINTF(EthernetEEPROM, "EEPROM: opcode: %#X:%d
addr: %#X:%d\n",
(uint32_t)eeOpcode, (uint32_t) eeOpBits,
- (uint32_t)eeAddr>>1, (uint32_t)eeAddrBits);
+ (uint32_t)eeAddr >> 1, (uint32_t)eeAddrBits);
if (eeOpBits == 8 && !(eeOpcode == EEPROM_READ_OPCODE_SPI ||
eeOpcode == EEPROM_RDSR_OPCODE_SPI ))
panic("Unknown eeprom opcode: %#X:%d\n",
(uint32_t)eeOpcode,
@@ -495,7 +496,7 @@
regs.icr(), regs.imr, regs.iam, regs.ctrl_ext.iame());
if (regs.ctrl_ext.iame())
regs.imr &= ~regs.iam;
- regs.icr = ~bits(val,30,0) & regs.icr();
+ regs.icr = ~bits(val, 30, 0) & regs.icr();
chkInterrupt();
break;
case REG_ITR:
@@ -569,7 +570,7 @@
regs.fcrth = val;
break;
case REG_RDBAL:
- regs.rdba.rdbal( val & ~mask(4));
+ regs.rdba.rdbal(val & ~mask(4));
rxDescCache.areaChanged();
break;
case REG_RDBAH:
@@ -607,7 +608,7 @@
regs.rxdctl = val;
break;
case REG_TDBAL:
- regs.tdba.tdbal( val & ~mask(4));
+ regs.tdba.tdbal(val & ~mask(4));
txDescCache.areaChanged();
break;
case REG_TDBAH:
@@ -681,9 +682,9 @@
regs.sw_fw_sync = val;
break;
default:
- if (!IN_RANGE(daddr, REG_VFTA, VLAN_FILTER_TABLE_SIZE*4) &&
- !IN_RANGE(daddr, REG_RAL, RCV_ADDRESS_TABLE_SIZE*8) &&
- !IN_RANGE(daddr, REG_MTA, MULTICAST_TABLE_SIZE*4))
+ if (!IN_RANGE(daddr, REG_VFTA, VLAN_FILTER_TABLE_SIZE * 4) &&
+ !IN_RANGE(daddr, REG_RAL, RCV_ADDRESS_TABLE_SIZE * 8) &&
+ !IN_RANGE(daddr, REG_MTA, MULTICAST_TABLE_SIZE * 4))
panic("Write request to unknown register number: %#x\n",
daddr);
};
@@ -921,7 +922,7 @@
assert(wbOut);
igbe->dmaWrite(pciToDma(descBase() + descHead() * sizeof(T)),
- wbOut * sizeof(T), &wbEvent, (uint8_t*)wbBuf,
+ wbOut * sizeof(T), &wbEvent, (uint8_t *)wbBuf,
igbe->wbCompDelay);
}
@@ -980,7 +981,7 @@
curFetching * sizeof(T));
assert(curFetching);
igbe->dmaRead(pciToDma(descBase() + cachePnt * sizeof(T)),
- curFetching * sizeof(T), &fetchEvent, (uint8_t*)fetchBuf,
+ curFetching * sizeof(T), &fetchEvent, (uint8_t
*)fetchBuf,
igbe->fetchCompDelay);
}
@@ -1082,14 +1083,14 @@
SERIALIZE_SCALAR(usedCacheSize);
for (typename CacheType::size_type x = 0; x < usedCacheSize; x++) {
arrayParamOut(cp, csprintf("usedCache_%d", x),
- (uint8_t*)usedCache[x],sizeof(T));
+ (uint8_t *)usedCache[x], sizeof(T));
}
typename CacheType::size_type unusedCacheSize = unusedCache.size();
SERIALIZE_SCALAR(unusedCacheSize);
for (typename CacheType::size_type x = 0; x < unusedCacheSize; x++) {
arrayParamOut(cp, csprintf("unusedCache_%d", x),
- (uint8_t*)unusedCache[x],sizeof(T));
+ (uint8_t *)unusedCache[x], sizeof(T));
}
Tick fetch_delay = 0, wb_delay = 0;
@@ -1119,7 +1120,7 @@
for (typename CacheType::size_type x = 0; x < usedCacheSize; x++) {
temp = new T;
arrayParamIn(cp, csprintf("usedCache_%d", x),
- (uint8_t*)temp,sizeof(T));
+ (uint8_t *)temp, sizeof(T));
usedCache.push_back(temp);
}
@@ -1128,7 +1129,7 @@
for (typename CacheType::size_type x = 0; x < unusedCacheSize; x++) {
temp = new T;
arrayParamIn(cp, csprintf("unusedCache_%d", x),
- (uint8_t*)temp,sizeof(T));
+ (uint8_t *)temp, sizeof(T));
unusedCache.push_back(temp);
}
Tick fetch_delay = 0, wb_delay = 0;
@@ -1495,7 +1496,7 @@
///////////////////////////// IGbE::TxDescCache
//////////////////////////////
IGbE::TxDescCache::TxDescCache(IGbE *i, const std::string n, int s)
- : DescCache<TxDesc>(i,n, s), pktDone(false), isTcp(false),
+ : DescCache<TxDesc>(i, n, s), pktDone(false), isTcp(false),
pktWaiting(false), pktMultiDesc(false),
completionAddress(0), completionEnabled(false),
useTso(false), tsoHeaderLen(0), tsoMss(0), tsoTotalLen(0),
tsoUsedLen(0),
@@ -1679,7 +1680,7 @@
DPRINTF(EthernetDesc,
"Loading TSO header (%d bytes) into start of packet\n",
tsoHeaderLen);
- memcpy(p->data, &tsoHeader,tsoHeaderLen);
+ memcpy(p->data, &tsoHeader, tsoHeaderLen);
p->length +=tsoHeaderLen;
tsoPktHasHeader = true;
}
@@ -1738,7 +1739,7 @@
if ((!txd_op::eop(desc) && !useTso) ||
- (pktPtr->length < ( tsoMss + tsoHeaderLen) &&
+ (pktPtr->length < (tsoMss + tsoHeaderLen) &&
tsoTotalLen != tsoUsedLen && useTso)) {
assert(!useTso || (tsoDescBytesUsed == txd_op::getLen(desc)));
unusedCache.pop_front();
@@ -1909,7 +1910,7 @@
"Completion writing back value: %d to addr: %#x\n",
descEnd,
completionAddress);
igbe->dmaWrite(pciToDma(mbits(completionAddress, 63, 2)),
- sizeof(descEnd), &nullEvent, (uint8_t*)&descEnd, 0);
+ sizeof(descEnd), &nullEvent, (uint8_t *)&descEnd,
0);
}
}
@@ -2369,7 +2370,7 @@
SERIALIZE_SCALAR(eeOpcode);
SERIALIZE_SCALAR(eeAddr);
SERIALIZE_SCALAR(lastInterrupt);
- SERIALIZE_ARRAY(flash,igbreg::EEPROM_SIZE);
+ SERIALIZE_ARRAY(flash, igbreg::EEPROM_SIZE);
rxFifo.serialize("rxfifo", cp);
txFifo.serialize("txfifo", cp);
@@ -2420,7 +2421,7 @@
UNSERIALIZE_SCALAR(eeOpcode);
UNSERIALIZE_SCALAR(eeAddr);
UNSERIALIZE_SCALAR(lastInterrupt);
- UNSERIALIZE_ARRAY(flash,igbreg::EEPROM_SIZE);
+ UNSERIALIZE_ARRAY(flash, igbreg::EEPROM_SIZE);
rxFifo.unserialize("rxfifo", cp);
txFifo.unserialize("txfifo", cp);
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48926
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9841a80172d3f1edfe68d9d4571535fe253f465e
Gerrit-Change-Number: 48926
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
