Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48708 )
Change subject: cpu-minor: Use the RegClassInfo::regName method instead of
THE_ISA.
......................................................................
cpu-minor: Use the RegClassInfo::regName method instead of THE_ISA.
Jira Issue: https://gem5.atlassian.net/browse/GEM5-1060
Change-Id: I43b31897ed3a9e77c6d2908ac4a04f705a0f74f2
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48708
Reviewed-by: Hoa Nguyen <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/cpu/minor/dyn_inst.cc
1 file changed, 1 insertion(+), 8 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/minor/dyn_inst.cc b/src/cpu/minor/dyn_inst.cc
index 4fe2f5a..5a4ef37 100644
--- a/src/cpu/minor/dyn_inst.cc
+++ b/src/cpu/minor/dyn_inst.cc
@@ -147,14 +147,7 @@
case MiscRegClass:
{
RegIndex misc_reg = reg.index();
-
- /* This is an ugly test because not all archs. have miscRegName */
-#if THE_ISA == ARM_ISA
- os << 'm' << misc_reg << '(' << TheISA::miscRegName[misc_reg]
<<
- ')';
-#else
- os << 'n' << misc_reg;
-#endif
+ os << 'm' << misc_reg << '(' << reg_class.regName(reg) << ')';
}
break;
case FloatRegClass:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48708
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I43b31897ed3a9e77c6d2908ac4a04f705a0f74f2
Gerrit-Change-Number: 48708
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: ZHENGRONG WANG <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
