Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/48964 )
Change subject: scons: Keep the list of all CPU models in a construction
variable.
......................................................................
scons: Keep the list of all CPU models in a construction variable.
This relaxes ordering around CPU model declaration.
Change-Id: Ie5f8da1903a883bd4d98800dfbef7fd913021f77
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/48964
Tested-by: kokoro <[email protected]>
Reviewed-by: Hoa Nguyen <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/cpu/SConsopts
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, but someone else must approve
Bobby R. Bruce: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/cpu/SConsopts b/src/cpu/SConsopts
index 2dec0d5..af35a20 100644
--- a/src/cpu/SConsopts
+++ b/src/cpu/SConsopts
@@ -25,12 +25,12 @@
Import('*')
-all_cpus = set()
def CpuModel(name):
- all_cpus.add(name)
+ main.Append(ALL_CPU_MODELS=[name])
Export('CpuModel')
def add_cpu_models_var():
- sticky_vars.Add(ListVariable('CPU_MODELS', 'CPU models', [], all_cpus))
+ sticky_vars.Add(ListVariable('CPU_MODELS', 'CPU models', [],
+ set(main.get('ALL_CPU_MODELS', []))))
AfterSConsopts(add_cpu_models_var)
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48964
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie5f8da1903a883bd4d98800dfbef7fd913021f77
Gerrit-Change-Number: 48964
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
