Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49405 )
Change subject: gpu-compute: Delete code related to X86PagetableWalker in
X86GPUTLB.py.
......................................................................
gpu-compute: Delete code related to X86PagetableWalker in X86GPUTLB.py.
This code will never be executed since FULL_SYSTEM is not part of the
build environment (and hasn't been for many years), and on top of that,
this declaration redundantly (and incompletely) tries to set up the
X86PagetableWalker that the ISA already sets up.
Change-Id: I40cffbd7f60c1f741b1a14d9009f80185c9ce28c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49405
Tested-by: kokoro <[email protected]>
Reviewed-by: Matthew Poremba <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M src/gpu-compute/X86GPUTLB.py
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
kokoro: Regressions pass
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
diff --git a/src/gpu-compute/X86GPUTLB.py b/src/gpu-compute/X86GPUTLB.py
index ce87ea7..ab14bf8 100644
--- a/src/gpu-compute/X86GPUTLB.py
+++ b/src/gpu-compute/X86GPUTLB.py
@@ -36,13 +36,6 @@
from m5.objects.ClockedObject import ClockedObject
from m5.SimObject import SimObject
-if buildEnv.get('FULL_SYSTEM', False):
- class X86PagetableWalker(SimObject):
- type = 'X86PagetableWalker'
- cxx_class = 'gem5::X86ISA::Walker'
- port = ResponsePort("Port for the hardware table walker")
- system = Param.System(Parent.any, "system object")
-
class X86GPUTLB(ClockedObject):
type = 'X86GPUTLB'
cxx_class = 'gem5::X86ISA::GpuTLB'
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49405
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I40cffbd7f60c1f741b1a14d9009f80185c9ce28c
Gerrit-Change-Number: 49405
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Alex Dutu <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Matt Sinclair <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
