Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/49616 )
Change subject: mem,base: Fix signed/unsigned comparison warnings/errors.
......................................................................
mem,base: Fix signed/unsigned comparison warnings/errors.
Change-Id: Icf477f4b0c162f0174216e511960d0e76db313ae
---
M src/base/addr_range.hh
M src/mem/packet.hh
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/base/addr_range.hh b/src/base/addr_range.hh
index 640f692..04dc8ec 100644
--- a/src/base/addr_range.hh
+++ b/src/base/addr_range.hh
@@ -334,7 +334,7 @@
{
if (interleaved()) {
std::string str;
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
str += " ";
Addr mask = masks[i];
while (mask) {
@@ -443,7 +443,7 @@
bool in_range = a >= _start && a < _end;
if (in_range) {
auto sel = 0;
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
Addr masked = a & masks[i];
// The result of an xor operation is 1 if the number
// of bits set is odd or 0 othersize, thefore it
@@ -490,7 +490,7 @@
// Get the LSB set from each mask
int masks_lsb[masks.size()];
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
masks_lsb[i] = ctz64(masks[i]);
}
@@ -498,7 +498,7 @@
// discard them one by one starting.
std::sort(masks_lsb, masks_lsb + masks.size());
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
const int intlv_bit = masks_lsb[i];
if (intlv_bit > 0) {
// on every iteration we remove one bit from the input
@@ -528,13 +528,13 @@
// Get the LSB set from each mask
int masks_lsb[masks.size()];
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
masks_lsb[i] = ctz64(masks[i]);
}
// Add bits one-by-one from the LSB side.
std::sort(masks_lsb, masks_lsb + masks.size());
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
const int intlv_bit = masks_lsb[i];
if (intlv_bit > 0) {
// on every iteration we add one bit from the input
@@ -547,7 +547,7 @@
}
}
- for (int i = 0; i < masks.size(); i++) {
+ for (unsigned int i = 0; i < masks.size(); i++) {
const int lsb = ctz64(masks[i]);
const Addr intlv_bit = bits(intlvMatch, i);
// Calculate the mask ignoring the LSB
diff --git a/src/mem/packet.hh b/src/mem/packet.hh
index 1283ac9..88995f1 100644
--- a/src/mem/packet.hh
+++ b/src/mem/packet.hh
@@ -1286,7 +1286,7 @@
assert(req->getByteEnable().size() == getSize());
// Write only the enabled bytes
const uint8_t *base = getConstPtr<uint8_t>();
- for (int i = 0; i < getSize(); i++) {
+ for (unsigned int i = 0; i < getSize(); i++) {
if (req->getByteEnable()[i]) {
p[i] = *(base + i);
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49616
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Icf477f4b0c162f0174216e511960d0e76db313ae
Gerrit-Change-Number: 49616
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-CC: Gabe Black <gabebl...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
