Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49530 )
Change subject: util: Expand the valgrind suppressions file to the entire
libpython.
......................................................................
util: Expand the valgrind suppressions file to the entire libpython.
Suppress any valgrind error from *anywhere* in the libpython library.
There are ***many*** false positives in the python library, making the
output of valgrind almost useless without lots of suppressions. Rather
than suppress each error piecemeal, we can suppress any error which
originates in libpython to cover them all.
There will now be corner cases where a bug in gem5 causes some sort of
illegal access, etc, within the python library itself, but these sorts
of interactions/errors should be very rare. Suppressing the fountain of
false positives coming from libpython makes valgrind useable in general,
which IMO is a very worthwhile tradeoff.
Change-Id: I4869eeeb4aef5884ad52025b52c9616e0541f3e6
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49530
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M util/valgrind-suppressions
1 file changed, 11 insertions(+), 68 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/util/valgrind-suppressions b/util/valgrind-suppressions
index 6d0669a..947eb4b 100644
--- a/util/valgrind-suppressions
+++ b/util/valgrind-suppressions
@@ -1,117 +1,60 @@
{
python error
Memcheck:Cond
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Addr1
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Addr2
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Addr4
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Addr8
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Addr16
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Value1
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Value2
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Value4
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Value8
- fun:PyObject_Free
+ obj:*libpython3*
}
{
python error
Memcheck:Value16
- fun:PyObject_Free
-}
-
-{
- python error
- Memcheck:Cond
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Addr1
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Addr2
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Addr4
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Addr8
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Addr16
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Value1
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Value2
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Value4
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Value8
- fun:PyObject_Realloc
-}
-{
- python error
- Memcheck:Value16
- fun:PyObject_Realloc
+ obj:*libpython3*
}
{
zlib error
Memcheck:Cond
fun:inflateReset2
}
-
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49530
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4869eeeb4aef5884ad52025b52c9616e0541f3e6
Gerrit-Change-Number: 49530
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jui-min Lee <[email protected]>
Gerrit-Reviewer: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
