Nicolas Boichat has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49947 )
Change subject: base: Remove SOCK_CLOEXEC from socketCloexec.
......................................................................
base: Remove SOCK_CLOEXEC from socketCloexec.
63c53e21fed7 ("base: Add SOCK_CLOEXEC when creating/accepting sockets")
accidentally left SOCK_CLOEXEC as socketCloexec parameter, remove
it as socketCloexec will add that parameter, and it'll not compile
on platforms that do not provide the flag.
Change-Id: I30e6fa1824b0258a325b53422585a9a362de4dff
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49947
Reviewed-by: Yu-hsin Wang <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/base/socket.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
Yu-hsin Wang: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/socket.cc b/src/base/socket.cc
index f0aeb01..860249a 100644
--- a/src/base/socket.cc
+++ b/src/base/socket.cc
@@ -126,7 +126,7 @@
// only create socket if not already created by a previous call
if (fd == -1) {
- fd = socketCloexec(PF_INET, SOCK_STREAM | SOCK_CLOEXEC, 0);
+ fd = socketCloexec(PF_INET, SOCK_STREAM, 0);
if (fd < 0)
panic("Can't create socket:%s !", strerror(errno));
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49947
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I30e6fa1824b0258a325b53422585a9a362de4dff
Gerrit-Change-Number: 49947
Gerrit-PatchSet: 2
Gerrit-Owner: Nicolas Boichat <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nicolas Boichat <[email protected]>
Gerrit-Reviewer: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
