Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/50349 )
Change subject: sim: Drop a hack from MemPools which reset the free page.
......................................................................
sim: Drop a hack from MemPools which reset the free page.
This made it skip over 70 pages to be "what it was before" my page table
changes. I'm not sure what changes this is referring to, and the class
which manages page tables in the guest memory uses the allocPhysPages
method to allocate its memory and would cooperate with anything else
using this mechanism without having to have special accomodation.
I removed this hack and hello world seems to work fine, but there may be
some other test case which exposes some problems.
Change-Id: I16e0d8835452df9c3e79738a1eed05b4cc9372b7
---
M src/sim/mem_pool.cc
1 file changed, 0 insertions(+), 6 deletions(-)
diff --git a/src/sim/mem_pool.cc b/src/sim/mem_pool.cc
index 35e2fb4..9bf2739 100644
--- a/src/sim/mem_pool.cc
+++ b/src/sim/mem_pool.cc
@@ -141,12 +141,6 @@
for (const auto &mem : memories)
pools.emplace_back(pageShift, mem.start(), mem.end());
-
- /*
- * Set freePage to what it was before Gabe Black's page table changes
- * so allocations don't trample the page table entries.
- */
- pools[0].setFreePage(pools[0].freePage() + 70);
}
Addr
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50349
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I16e0d8835452df9c3e79738a1eed05b4cc9372b7
Gerrit-Change-Number: 50349
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
