Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49386 )
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: scons: Declare PySource Source files in the PySource
__init__.
......................................................................
scons: Declare PySource Source files in the PySource __init__.
There's no reason to wait until the end to loop over all PySource files
and declare their Source-s then.
Change-Id: I94de1b2123bb94324a647bbc005a923012080cab
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49386
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Hoa Nguyen <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
---
M src/SConscript
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Hoa Nguyen: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/SConscript b/src/SConscript
index f3cac80..8c5c2b9 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -175,6 +175,8 @@
marshal_env.Command(self.cpp, [ py_marshal, self.tnode ],
MakeAction(embedPyFile, Transform("EMBED PY")))
+ if main['USE_PYTHON']:
+ Source(self.cpp, tags=self.tags, add_tags='python')
class SimObject(PySource):
'''Add a SimObject python file as a python source object and add
@@ -957,10 +959,6 @@
Transform("VER TAGS")))
env.AlwaysBuild(tags)
-if main['USE_PYTHON']:
- for source in PySource.all:
- Source(source.cpp, tags=source.tags, add_tags='python')
-
########################################################################
#
# Define binaries. Each different build type (debug, opt, etc.) gets
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49386
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I94de1b2123bb94324a647bbc005a923012080cab
Gerrit-Change-Number: 49386
Gerrit-PatchSet: 12
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
