Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49390 )
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: scons: Get rid of a loop which touched all the param ptype
attributes.
......................................................................
scons: Get rid of a loop which touched all the param ptype attributes.
As far as I can tell, this code is left over from when gem5 used SWIG,
and is not necessary any more.
Change-Id: Id36887773d2fc1373ffe689ee1b50b4989bf5a38
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49390
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Hoa Nguyen <[email protected]>
---
M src/SConscript
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/SConscript b/src/SConscript
index f4e59a8..fdd5830 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -676,14 +676,6 @@
sim_objects = m5.SimObject.allClasses
all_enums = m5.params.allEnums
-for name,obj in sorted(sim_objects.items()):
- for param in obj._params.local.values():
- # load the ptype attribute now because it depends on the
- # current version of SimObject.allClasses, but when scons
- # actually uses the value, all versions of
- # SimObject.allClasses will have been loaded
- param.ptype
-
########################################################################
#
# calculate extra dependencies
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49390
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Id36887773d2fc1373ffe689ee1b50b4989bf5a38
Gerrit-Change-Number: 49390
Gerrit-PatchSet: 12
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
