Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49388 )
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: scons: Simplify the PySource class slightly.
......................................................................
scons: Simplify the PySource class slightly.
Demote the cpp attribute to a local variable, and get rid of the unused
"package" attribute.
Change-Id: I190792274ea9bdd9853aa3b6e07ce4151b378251
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49388
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
Reviewed-by: Hoa Nguyen <[email protected]>
---
M src/SConscript
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/SConscript b/src/SConscript
index a5b679c..2e48048 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -160,24 +160,24 @@
if not os.path.exists(abspath):
abspath = self.tnode.abspath
- self.package = package
self.modname = modname
self.modpath = modpath
self.abspath = abspath
- self.cpp = File(self.filename + '.cc')
PySource.modules[modpath] = self
+ cpp = File(self.filename + '.cc')
+
overrides = {
'PYSOURCE_MODPATH': modpath,
'PYSOURCE_ABSPATH': abspath,
}
- marshal_env.Command(self.cpp, [ py_marshal, File(source) ],
+ marshal_env.Command(cpp, [ py_marshal, File(source) ],
MakeAction(embedPyFile, Transform("EMBED PY"),
varlist=overrides.keys()),
**overrides)
if main['USE_PYTHON']:
- Source(self.cpp, tags=self.tags, add_tags='python')
+ Source(cpp, tags=self.tags, add_tags='python')
class SimObject(PySource):
'''Add a SimObject python file as a python source object and add
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49388
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I190792274ea9bdd9853aa3b6e07ce4151b378251
Gerrit-Change-Number: 49388
Gerrit-PatchSet: 12
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
