Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/50628 )
Change subject: scons: Fix checking the --install-hooks option in the "git"
tool.
......................................................................
scons: Fix checking the --install-hooks option in the "git" tool.
The option should be checked with 'install_hooks' and not
'install-hooks', even though the option is '--install-hooks' to the
user.
This bug was due to an incorrect review suggestion from me on this
original change:
https://gem5-review.googlesource.com/c/public/gem5/+/50410
JIRA: https://gem5.atlassian.net/browse/GEM5-1091
Change-Id: Ifb4526307bea015de1fe73d3d685477be711b7cb
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/50628
Maintainer: Gabe Black <[email protected]>
Reviewed-by: Eric Ye <[email protected]>
Reviewed-by: Hoa Nguyen <[email protected]>
Tested-by: kokoro <[email protected]>
---
M site_scons/site_tools/git.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hoa Nguyen: Looks good to me, approved
Eric Ye: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/site_scons/site_tools/git.py b/site_scons/site_tools/git.py
index e95c62f..fe083b7 100644
--- a/site_scons/site_tools/git.py
+++ b/site_scons/site_tools/git.py
@@ -100,7 +100,7 @@
return
print(git_style_message, end=' ')
- if SCons.Script.GetOption('install-hooks'):
+ if SCons.Script.GetOption('install_hooks'):
print("Installing revision control hooks automatically.")
else:
try:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50628
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ifb4526307bea015de1fe73d3d685477be711b7cb
Gerrit-Change-Number: 50628
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Eric Ye <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
