Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/51529 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: mem: Stop using SlavePort as a base class.
......................................................................
mem: Stop using SlavePort as a base class.
There are other classes like "ExternalSlave" which still have the word
"Slave" in them, but at least this will make the build quit complaining
about the deprecated SlavePort.
Change-Id: I917c2880574cb77ea37c69dc2727ac5e84b83cd5
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51529
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/external_slave.hh
1 file changed, 21 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/external_slave.hh b/src/mem/external_slave.hh
index 51c884b..17ab42a 100644
--- a/src/mem/external_slave.hh
+++ b/src/mem/external_slave.hh
@@ -69,7 +69,7 @@
{
public:
/** Derive from this class to create an external port interface */
- class ExternalPort : public SlavePort
+ class ExternalPort : public ResponsePort
{
protected:
ExternalSlave &owner;
@@ -77,7 +77,7 @@
public:
ExternalPort(const std::string &name_,
ExternalSlave &owner_) :
- SlavePort(name_, &owner_), owner(owner_)
+ ResponsePort(name_, &owner_), owner(owner_)
{ }
~ExternalPort() { }
@@ -90,7 +90,7 @@
/* Handlers are specific to *types* of port not specific port
* instantiations. A handler will typically build a bridge to the
- * external port from gem5 and provide gem5 with a SlavePort that can
be
+ * external port from gem5 and provide gem5 with a ResponsePort that
can be
* bound to for each call to Handler::getExternalPort.*/
class Handler
{
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51529
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I917c2880574cb77ea37c69dc2727ac5e84b83cd5
Gerrit-Change-Number: 51529
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
