Matt Sinclair has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/51687 )
Change subject: mem-ruby: fix typo in GPU VIPER TCC comment
......................................................................
mem-ruby: fix typo in GPU VIPER TCC comment
72ee6d1a fixed a deadlock in the GPU VIPER TCC. However, it
inadvertently added a typo to the comments explaining the change. This
commit fixes that.
Change-Id: Ibba835aa907be33fc3dd8e576ad2901d5f8f509c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51687
Maintainer: Matt Sinclair <mattdsincl...@gmail.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/mem/ruby/protocol/GPU_VIPER-TCC.sm
1 file changed, 21 insertions(+), 4 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Matt Sinclair: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/protocol/GPU_VIPER-TCC.sm
b/src/mem/ruby/protocol/GPU_VIPER-TCC.sm
index 571587f..dc6cf03 100644
--- a/src/mem/ruby/protocol/GPU_VIPER-TCC.sm
+++ b/src/mem/ruby/protocol/GPU_VIPER-TCC.sm
@@ -618,19 +618,19 @@
// they can cause a resource stall deadlock!
transition(WI, {RdBlk, WrVicBlk, Atomic, WrVicBlkBack}) {
//TagArrayRead} {
- // put putting the stalled requests in a buffer, we reduce resource
contention
+ // by putting the stalled requests in a buffer, we reduce resource
contention
// since they won't try again every cycle and will instead only try
again once
// woken up
st_stallAndWaitRequest;
}
transition(A, {RdBlk, WrVicBlk, WrVicBlkBack}) { //TagArrayRead} {
- // put putting the stalled requests in a buffer, we reduce resource
contention
+ // by putting the stalled requests in a buffer, we reduce resource
contention
// since they won't try again every cycle and will instead only try
again once
// woken up
st_stallAndWaitRequest;
}
transition(IV, {WrVicBlk, Atomic, WrVicBlkBack}) { //TagArrayRead} {
- // put putting the stalled requests in a buffer, we reduce resource
contention
+ // by putting the stalled requests in a buffer, we reduce resource
contention
// since they won't try again every cycle and will instead only try
again once
// woken up
st_stallAndWaitRequest;
@@ -681,7 +681,7 @@
transition(A, Atomic) {
p_profileMiss;
- // put putting the stalled requests in a buffer, we reduce resource
contention
+ // by putting the stalled requests in a buffer, we reduce resource
contention
// since they won't try again every cycle and will instead only try
again once
// woken up
st_stallAndWaitRequest;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51687
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibba835aa907be33fc3dd8e576ad2901d5f8f509c
Gerrit-Change-Number: 51687
Gerrit-PatchSet: 2
Gerrit-Owner: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Kyle Roarty <kyleroarty1...@gmail.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
