Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/50334 )
(
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch: Consolidate common debug flags.
......................................................................
arch: Consolidate common debug flags.
Consolidate debug flags which are defined separately in multiple ISAs in
arch/SConscript instead. This will prevent conflicts when more than one
ISA can be compiled at a time.
Change-Id: I70862c403d19f04bbcbabd74dd751ca92d1ed942
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/50334
Tested-by: kokoro <[email protected]>
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
---
M src/arch/riscv/SConscript
M src/arch/SConscript
M src/arch/x86/SConscript
M src/arch/arm/SConscript
4 files changed, 21 insertions(+), 6 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/SConscript b/src/arch/SConscript
index ecc0ca5..4922bda 100644
--- a/src/arch/SConscript
+++ b/src/arch/SConscript
@@ -225,3 +225,7 @@
DebugFlag('MiscRegs')
CompoundFlag('Registers',
[ 'IntRegs', 'FloatRegs', 'VecRegs', 'VecPredRegs',
'CCRegs', 'MiscRegs' ])
+
+DebugFlag('Decoder', "Decoder debug output")
+DebugFlag('Faults', "Information about faults, exceptions, interrupts,
etc")
+DebugFlag('TLBVerbose')
diff --git a/src/arch/arm/SConscript b/src/arch/arm/SConscript
index fbf4a44..c4a8b9e 100644
--- a/src/arch/arm/SConscript
+++ b/src/arch/arm/SConscript
@@ -111,10 +111,7 @@
DebugFlag('Arm')
DebugFlag('ArmTme', 'Transactional Memory Extension')
DebugFlag('Semihosting')
- DebugFlag('Decoder', "Instructions returned by the predecoder")
- DebugFlag('Faults', "Trace Exceptions, interrupts, svc/swi")
DebugFlag('PMUVerbose', "Performance Monitor")
- DebugFlag('TLBVerbose')
# Add files generated by the ISA description.
ISADesc('isa/main.isa', decoder_splits=3, exec_splits=6)
diff --git a/src/arch/riscv/SConscript b/src/arch/riscv/SConscript
index 4861c69..b9a0135 100644
--- a/src/arch/riscv/SConscript
+++ b/src/arch/riscv/SConscript
@@ -71,7 +71,6 @@
SimObject('RiscvTLB.py')
DebugFlag('RiscvMisc')
- DebugFlag('TLBVerbose')
DebugFlag('PMP')
# Add in files generated by the ISA description.
diff --git a/src/arch/x86/SConscript b/src/arch/x86/SConscript
index 6c9fdfa..1252116 100644
--- a/src/arch/x86/SConscript
+++ b/src/arch/x86/SConscript
@@ -72,9 +72,7 @@
SimObject('X86NativeTrace.py')
SimObject('X86TLB.py')
-DebugFlag('Faults', "Trace all faults/exceptions/traps")
DebugFlag('LocalApic', "Local APIC debugging")
-DebugFlag('Decoder', "Decoder debug output")
DebugFlag('X86', "Generic X86 ISA debugging")
DebugFlag('ACPI', "ACPI debugging")
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50334
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I70862c403d19f04bbcbabd74dd751ca92d1ed942
Gerrit-Change-Number: 50334
Gerrit-PatchSet: 7
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Hoa Nguyen <[email protected]>
Gerrit-Reviewer: Jui-min Lee <[email protected]>
Gerrit-Reviewer: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
