Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/51827 )
Change subject: arch: Correct the direction of the arch->gem5 lib tag
implication.
......................................................................
arch: Correct the direction of the arch->gem5 lib tag implication.
The arch implies gem5 lib, and not the other way around. Or in other
words, if, for example, x86 is the ISA, the having the tag 'x86 isa'
would imply that that file also has the tag 'gem5 lib'. Having the tag
'gem5 lib' would not imply 'x86 isa'.
This worked out because when testing for a single tag, we were using
with_any_tags, and 'gem5 lib' would expand to 'gem5 lib' and 'x86 isa'.
Then we would match files which were non-specific and used 'gem5 lib',
or files which had more specifically used 'x86 isa' only. Files which
used, for instance, 'arm isa', would not meet either criteria of the
implied "or".
Change-Id: I301d1bbbbcac1594371584d4b0d5d291b7b77fc4
---
M src/arch/SConscript
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/src/arch/SConscript b/src/arch/SConscript
index 4922bda..2616768 100644
--- a/src/arch/SConscript
+++ b/src/arch/SConscript
@@ -55,7 +55,7 @@
#
#################################################################
-env.TagImplies('gem5 lib', env.subst('${TARGET_ISA} isa'))
+env.TagImplies(env.subst('${TARGET_ISA} isa'), 'gem5 lib')
env.SwitchingHeaders(
Split('''
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/51827
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I301d1bbbbcac1594371584d4b0d5d291b7b77fc4
Gerrit-Change-Number: 51827
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
