Attention is currently required from: Bobby R. Bruce, Jason Lowe-Power.
Hello kokoro, Bobby R. Bruce, Jason Lowe-Power,
I'd like you to do a code review.
Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/52264
to review the following change.
Change subject: Revert "base-stats: Fixed System "work_item" stat name"
......................................................................
Revert "base-stats: Fixed System "work_item" stat name"
This reverts commit 53b5ae1013e1795c73859930a7a87d59524d0657.
Reason for revert: setName() in src/base/stats/info.cc checks whether a
name is repeated. Having multiple System() instance would fail that check.
Change-Id: I5d4a78e8da99a8a644f58fd1a421ac7a7ffc9a4a
---
M src/sim/system.cc
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/sim/system.cc b/src/sim/system.cc
index 4a9c6cd..93902af 100644
--- a/src/sim/system.cc
+++ b/src/sim/system.cc
@@ -483,7 +483,7 @@
std::stringstream namestr;
ccprintf(namestr, "work_item_type%d", j);
workItemStats[j]->init(20)
- .name(namestr.str())
+ .name(name() + "." + namestr.str())
.desc("Run time stat for" + namestr.str())
.prereq(*workItemStats[j]);
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52264
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I5d4a78e8da99a8a644f58fd1a421ac7a7ffc9a4a
Gerrit-Change-Number: 52264
Gerrit-PatchSet: 1
Gerrit-Owner: Han-sheng Liu <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-Attention: Bobby R. Bruce <[email protected]>
Gerrit-Attention: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
