Yu-hsin Wang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52685 )
Change subject: arch-arm: add missing override for remote_gdb
......................................................................
arch-arm: add missing override for remote_gdb
Change-Id: Iecbf56d97784367e416f950658515343734f3bec
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52685
Reviewed-by: Earl Ou <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/remote_gdb.hh
1 file changed, 20 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
Earl Ou: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/remote_gdb.hh b/src/arch/arm/remote_gdb.hh
index 847dee7..5c5a37d 100644
--- a/src/arch/arm/remote_gdb.hh
+++ b/src/arch/arm/remote_gdb.hh
@@ -63,7 +63,7 @@
class RemoteGDB : public BaseRemoteGDB
{
protected:
- bool acc(Addr addr, size_t len);
+ bool acc(Addr addr, size_t len) override;
class AArch32GdbRegCache : public BaseGdbRegCache
{
@@ -119,13 +119,14 @@
public:
RemoteGDB(System *_system, int _port);
- BaseGdbRegCache *gdbRegs();
+ BaseGdbRegCache *gdbRegs() override;
std::vector<std::string>
- availableFeatures() const
+ availableFeatures() const override
{
return {"qXfer:features:read+"};
};
- bool getXferFeaturesRead(const std::string &annex, std::string
&output);
+ bool getXferFeaturesRead(const std::string &annex,
+ std::string &output) override;
};
} // namespace ArmISA
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52685
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iecbf56d97784367e416f950658515343734f3bec
Gerrit-Change-Number: 52685
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Earl Ou <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Yu-hsin Wang <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
