Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52107 )
Change subject: sim: Remove some old transitional code in SEWorkload.
......................................................................
sim: Remove some old transitional code in SEWorkload.
This code was just to catch cases where the SEWorkload init_compatible
function couldn't find a compatible SEWorkload subclass. Now that all of
these classes are set up with this mechanism, there's no need to keep
this code around.
Change-Id: Ie847f5a90ccf98eb58c149a22a6881529344946d
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52107
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/sim/Workload.py
1 file changed, 18 insertions(+), 4 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/Workload.py b/src/sim/Workload.py
index bd1a230..52bda94 100644
--- a/src/sim/Workload.py
+++ b/src/sim/Workload.py
@@ -102,10 +102,6 @@
if len(options) > 1:
raise ValueError("More than one SE workload is compatible
with %s")
elif len(options) < 1:
- # For now, fall back to the base class if there are no matches.
- # After we've had a chance to implement everything, this
default
- # can be removed since this should always find exactly one
match.
- return SEWorkload(*args, **kwargs)
raise ValueError("No SE workload is compatible with %s", path)
return options[0](*args, **kwargs)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52107
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie847f5a90ccf98eb58c149a22a6881529344946d
Gerrit-Change-Number: 52107
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Earl Ou <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
