Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52046 )
(
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: misc: Use a PCStateBase unique_ptr in
SkipFuncBase::process.
......................................................................
misc: Use a PCStateBase unique_ptr in SkipFuncBase::process.
Change-Id: I0ffcf3abeaa7704a3b6eaccfd967a9654f59c741
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52046
Tested-by: kokoro <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
Reviewed-by: Daniel Carvalho <[email protected]>
---
M src/kern/system_events.cc
1 file changed, 15 insertions(+), 2 deletions(-)
Approvals:
Daniel Carvalho: Looks good to me, approved
Bobby R. Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/kern/system_events.cc b/src/kern/system_events.cc
index 816f158..19d7cb1 100644
--- a/src/kern/system_events.cc
+++ b/src/kern/system_events.cc
@@ -39,12 +39,12 @@
void
SkipFuncBase::process(ThreadContext *tc)
{
- [[maybe_unused]] TheISA::PCState oldPC = tc->pcState();
+ std::unique_ptr<PCStateBase> old_pc(tc->pcState().clone());
returnFromFuncIn(tc);
DPRINTF(PCEvent, "skipping %s: pc = %s, newpc = %s\n", description,
- oldPC, tc->pcState());
+ *old_pc, tc->pcState());
}
} // namespace gem5
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52046
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0ffcf3abeaa7704a3b6eaccfd967a9654f59c741
Gerrit-Change-Number: 52046
Gerrit-PatchSet: 14
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s