Chen Zou has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/53283 )
Change subject: base-stats: HDF5 calls with better compatibility
......................................................................
base-stats: HDF5 calls with better compatibility
H5Object.getObjName() is added at HDF5 V1.8.13.
As an example, compilation error would be thrown on CentOS 7.
obj.getObjnameByIdx(obj.getId()) would work with older versions.
Change-Id: I104eaac050db7501ab3a1aa3ad6dc1ee8b8d7e22
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53283
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/base/stats/hdf5.cc
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/stats/hdf5.cc b/src/base/stats/hdf5.cc
index d5b7f1e..03574b2 100644
--- a/src/base/stats/hdf5.cc
+++ b/src/base/stats/hdf5.cc
@@ -257,7 +257,7 @@
fspace = H5::DataSpace(rank, dims, max_dims.data());
try {
DPRINTF(Stats, "Creating dataset %s in group %s\n",
- info.name, group.getObjName());
+ info.name, group.getObjnameByIdx(group.getId()));
data_set = group.createDataSet(info.name,
H5::PredType::NATIVE_DOUBLE, fspace, props);
} catch (const H5::Exception &e) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53283
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I104eaac050db7501ab3a1aa3ad6dc1ee8b8d7e22
Gerrit-Change-Number: 53283
Gerrit-PatchSet: 3
Gerrit-Owner: Chen Zou <chen...@uchicago.edu>
Gerrit-Reviewer: Chen Zou <chen...@uchicago.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
