Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/53846 )
Change subject: stdlib,configs: Set SPEC examples partition param to
optional
......................................................................
stdlib,configs: Set SPEC examples partition param to optional
The SPEC2006 and SPEC2017 example configs require the passing of SPEC
disk image to function correctly. Prior to this commit a root partition
parameter was required. However, disk images don't necessarily have
partitions. In this case an empty string needed passed.
This patch makes the root partition parameter optional. If a disk image
does not have a root partition, it does not need specified.
Change-Id: Ic0093c70c72ab83ffaca54c8ad24245d84a5e5ba
---
M configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
M configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
index 0deb48f..139354e 100644
--- a/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2006-benchmarks.py
@@ -117,7 +117,8 @@
parser.add_argument(
"--partition",
type = str,
- required = True,
+ required = False,
+ default=None,
help = "Input the root partition of the SPEC disk-image. If the disk
is \
not partitioned, then pass \"\"."
)
diff --git a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
index 012867d..f252155 100644
--- a/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
+++ b/configs/example/gem5_library/x86-spec-cpu2017-benchmarks.py
@@ -123,7 +123,8 @@
parser.add_argument(
"--partition",
type = str,
- required = True,
+ required = False,
+ default=None,
help = "Input the root partition of the SPEC disk-image. If the disk
is \
not partitioned, then pass \"\"."
)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/53846
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic0093c70c72ab83ffaca54c8ad24245d84a5e5ba
Gerrit-Change-Number: 53846
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
