Hey Boris, Feel free to make a gerrit change request to the CONTRIBUTING.md file. We can discuss more there.
>From my perspective, it's not a big deal to me what the conjugation of a change request is. As long as it's clear, I'm ok with whatever. I'm also OK with putting a preference in the CONTRIBUTING document. However, I think it's unlikely that this will be strictly enforced, especially because we don't have bot for it :). Cheers, Jason On Sat, Dec 18, 2021 at 12:24 PM Boris Shingarov via gem5-dev < [email protected]> wrote: > I was reading through this relation-chain and the only thing that looked > not quite right is the inconsistent commit message style: some of these > commits have it in indicative mood, sometimes in imperative, sometimes > plural and sometimes singular. Frankly this is rather distracting. I was > hoping that somewhere on the "Contributing" page the standard what the > commit message should look like would be spelled out. For example in the > Eclipse project we say this on the "Contributing" page: "The first line > describes the change made. It is written in the imperative mood, and should > say what happens when the patch is applied. ..." ( > https://github.com/eclipse-openj9/openj9/blob/master/CONTRIBUTING.md) To > my surprise, gem5's "Contributing" page is silent on this matter -- > although (at least on the few first pages of the commit log) all other > commits but the ones in this relation-chain are consistent. > > What is the procedure for PRs to the Contributing Guide? > > > -----"Bobby Bruce via gem5-dev" <[email protected]> wrote: ----- > To: "gem5 Developer List" <[email protected]> > From: "Bobby Bruce via gem5-dev" <[email protected]> > Date: 12/03/2021 09:43PM > Cc: "Melissa Jost" <[email protected]>, [email protected], "Joël > Porquet-Lupine" <[email protected]>, "Bobby Bruce" <[email protected]> > Subject: [gem5-dev] LupIO: Friendly IO Devices for gem5 (reviews > appreciated!) > > Dear all, > > Here at UC Davis two undergraduate students, Melissa Jost and Laura > Hinman, have been working on incorporating LupIO devices into gem5. > > For those unaware, LupIO devices were developed by Prof. Joel > Porquet-Lupine as a set of open-source I/O devices to be used for teaching. > They were designed to model a complete set of I/O devices that are neither > too complex to teach in a classroom setting, or too simple to translate to > understanding real-world devices. Our collection consists of a real-time > clock, random number generator, terminal device, block device, system > controller, timer device, programmable interrupt controller, as well as an > inter-processor interrupt controller. A more detailed outline of LupIO can > be found here: > https://luplab.cs.ucdavis.edu/assets/lupio/wcae21-porquet-lupio-paper.pdf > . Within gem5, these devices offer the capability to run simulations with a > complete set of I/O devices that are both easy to understand and manipulate. > > Prior to Melissa and Laura's work these devices were only available for > use with QEMU. They have worked diligently over the past term to > incorporate these into gem5 for the RISCV ISA. They have incrementally > added each device into gem5, and into a LupV gem5 Board (LupvBoard) which, > when using gem5 alongside the correct device drivers in Linux, provides the > capability of booting a RISC-V Linux system with SMP support. > > At present this work exists as a relation-chain in Gerrit: > https://gem5-review.googlesource.com/c/public/gem5/+/53040. We would > appreciate feedback on this relation-chain by those interested in this > work. We hope we can get this chain submitted into the develop branch soon > so it can be part of the gem5 v21.2 release. > > For those interested in setting up and running the LupvBoard, an example > configuration script has been included at the top of the relation chain: > https://gem5-review.googlesource.com/c/public/gem5/+/53046. > > Kind regards, > Bobby > > -- > Dr. Bobby R. Bruce > Room 3050, > Kemper Hall, UC Davis > Davis, > CA, 95616 > > web: https://www.bobbybruce.net > _______________________________________________ > gem5-dev mailing list -- [email protected] > To unsubscribe send an email to [email protected] > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s > _______________________________________________ > gem5-dev mailing list -- [email protected] > To unsubscribe send an email to [email protected] > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s >
_______________________________________________ gem5-dev mailing list -- [email protected] To unsubscribe send an email to [email protected] %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
