Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55451 )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-x86: In the LVT in the local APIC, start with all
entries masked.
......................................................................
arch-x86: In the LVT in the local APIC, start with all entries masked.
This is what the APIC is supposed to look like when coming out of reset.
Change-Id: Ia9b6e13533692109849e729d9ad3b358f36e2e47
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55451
Reviewed-by: Matt Sinclair <[email protected]>
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Matt Sinclair <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/x86/interrupts.cc
1 file changed, 29 insertions(+), 0 deletions(-)
Approvals:
Matt Sinclair: Looks good to me, but someone else must approve; Looks
good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/x86/interrupts.cc b/src/arch/x86/interrupts.cc
index 80ed3a6..8499bfb 100644
--- a/src/arch/x86/interrupts.cc
+++ b/src/arch/x86/interrupts.cc
@@ -616,6 +616,19 @@
ISRV = 0;
IRRV = 0;
+ // At reset, all LVT entries start out zeroed, except for their mask
bit.
+ LVTEntry masked = 0;
+ masked.masked = 1;
+
+ regs[APIC_LVT_TIMER] = masked;
+ regs[APIC_LVT_THERMAL_SENSOR] = masked;
+ regs[APIC_LVT_PERFORMANCE_MONITORING_COUNTERS] = masked;
+ regs[APIC_LVT_LINT0] = masked;
+ regs[APIC_LVT_LINT1] = masked;
+ regs[APIC_LVT_ERROR] = masked;
+
+ regs[APIC_SPURIOUS_INTERRUPT_VECTOR] = 0xff;
+
regs[APIC_VERSION] = (5 << 16) | 0x14;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55451
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia9b6e13533692109849e729d9ad3b358f36e2e47
Gerrit-Change-Number: 55451
Gerrit-PatchSet: 5
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
