Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49165 )
Change subject: arch: Get rid of the TheISA::NumVecElemPerVecReg variable.
......................................................................
arch: Get rid of the TheISA::NumVecElemPerVecReg variable.
Remove it from the arch/vecregs.hh interface. It's used internally by
ARM, where it will remain.
Change-Id: Ic319b404cbd77875c780faee66d5abdd7bfc0608
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49165
Reviewed-by: Bobby Bruce <bbr...@ucdavis.edu>
Reviewed-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/generic/vec_reg.hh
M src/arch/mips/vecregs.hh
M src/arch/null/vecregs.hh
M src/arch/power/vecregs.hh
M src/arch/riscv/vecregs.hh
M src/arch/sparc/vecregs.hh
M src/arch/x86/vecregs.hh
7 files changed, 18 insertions(+), 9 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
Bobby Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/generic/vec_reg.hh b/src/arch/generic/vec_reg.hh
index 34ba554..dfdc985 100644
--- a/src/arch/generic/vec_reg.hh
+++ b/src/arch/generic/vec_reg.hh
@@ -264,9 +264,7 @@
*/
/** @{ */
using DummyVecElem = uint32_t;
-constexpr unsigned DummyNumVecElemPerVecReg = 2;
-using DummyVecRegContainer =
- VecRegContainer<DummyNumVecElemPerVecReg * sizeof(DummyVecElem)>;
+using DummyVecRegContainer = VecRegContainer<2 * sizeof(DummyVecElem)>;
/** @} */
} // namespace gem5
diff --git a/src/arch/mips/vecregs.hh b/src/arch/mips/vecregs.hh
index 0c8b86a..96dd881 100644
--- a/src/arch/mips/vecregs.hh
+++ b/src/arch/mips/vecregs.hh
@@ -42,7 +42,6 @@
// Not applicable to MIPS
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to MIPS
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
diff --git a/src/arch/null/vecregs.hh b/src/arch/null/vecregs.hh
index 81c2f0d..0476554 100644
--- a/src/arch/null/vecregs.hh
+++ b/src/arch/null/vecregs.hh
@@ -52,7 +52,6 @@
// Not applicable to null
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to null
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
diff --git a/src/arch/power/vecregs.hh b/src/arch/power/vecregs.hh
index 9f557ce..767a4be 100644
--- a/src/arch/power/vecregs.hh
+++ b/src/arch/power/vecregs.hh
@@ -44,7 +44,6 @@
// Not applicable to Power
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to Power
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
diff --git a/src/arch/riscv/vecregs.hh b/src/arch/riscv/vecregs.hh
index 51fd244..8bc0656 100644
--- a/src/arch/riscv/vecregs.hh
+++ b/src/arch/riscv/vecregs.hh
@@ -60,7 +60,6 @@
// Not applicable to RISC-V
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to RISC-V
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
diff --git a/src/arch/sparc/vecregs.hh b/src/arch/sparc/vecregs.hh
index bb5c038..1e4c1f9 100644
--- a/src/arch/sparc/vecregs.hh
+++ b/src/arch/sparc/vecregs.hh
@@ -41,7 +41,6 @@
// Not applicable to SPARC
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to SPARC
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
diff --git a/src/arch/x86/vecregs.hh b/src/arch/x86/vecregs.hh
index 578360b..d03c7c2 100644
--- a/src/arch/x86/vecregs.hh
+++ b/src/arch/x86/vecregs.hh
@@ -55,7 +55,6 @@
// Not applicable to x86
using VecElem = ::gem5::DummyVecElem;
using VecRegContainer = ::gem5::DummyVecRegContainer;
-constexpr unsigned NumVecElemPerVecReg = ::gem5::DummyNumVecElemPerVecReg;
// Not applicable to x86
using VecPredRegContainer = ::gem5::DummyVecPredRegContainer;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49165
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ic319b404cbd77875c780faee66d5abdd7bfc0608
Gerrit-Change-Number: 49165
Gerrit-PatchSet: 38
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Daniel Carvalho <oda...@yahoo.com.br>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
