Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55705 )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-arm: Define an Affinity type
......................................................................
arch-arm: Define an Affinity type
Signed-off-by: Giacomo Travaglini <[email protected]>
Change-Id: I42461de26886b1ba9e4db5b23a9fb970d3a1efd7
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55705
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/types.hh
M src/arch/arm/utility.cc
M src/arch/arm/utility.hh
3 files changed, 32 insertions(+), 7 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/types.hh b/src/arch/arm/types.hh
index a4d1f33..734fe6f 100644
--- a/src/arch/arm/types.hh
+++ b/src/arch/arm/types.hh
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2010, 2012-2013, 2017-2018 ARM Limited
+ * Copyright (c) 2010, 2012-2013, 2017-2018, 2022 Arm Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@@ -202,6 +202,13 @@
Bitfield<11, 8> ltcoproc;
EndBitUnion(ExtMachInst)
+ BitUnion32(Affinity)
+ Bitfield<31, 24> aff3;
+ Bitfield<23, 16> aff2;
+ Bitfield<15, 8> aff1;
+ Bitfield<7, 0> aff0;
+ EndBitUnion(Affinity)
+
// Shift types for ARM instructions
enum ArmShiftType
{
diff --git a/src/arch/arm/utility.cc b/src/arch/arm/utility.cc
index f81255d..6852aed 100644
--- a/src/arch/arm/utility.cc
+++ b/src/arch/arm/utility.cc
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2009-2014, 2016-2020 ARM Limited
+ * Copyright (c) 2009-2014, 2016-2020, 2022 Arm Limited
* All rights reserved.
*
* The license below extends only to copyright in the software and shall
@@ -199,13 +199,13 @@
static RegVal
getAff2(ArmSystem *arm_sys, ThreadContext *tc)
{
- return arm_sys->multiThread ? tc->socketId() << 16 : 0;
+ return arm_sys->multiThread ? tc->socketId() : 0;
}
static RegVal
getAff1(ArmSystem *arm_sys, ThreadContext *tc)
{
- return arm_sys->multiThread ? tc->cpuId() << 8 : tc->socketId() << 8;
+ return arm_sys->multiThread ? tc->cpuId() : tc->socketId();
}
static RegVal
@@ -214,10 +214,14 @@
return arm_sys->multiThread ? tc->threadId() : tc->cpuId();
}
-RegVal
+Affinity
getAffinity(ArmSystem *arm_sys, ThreadContext *tc)
{
- return getAff2(arm_sys, tc) | getAff1(arm_sys, tc) | getAff0(arm_sys,
tc);
+ Affinity aff = 0;
+ aff.aff0 = getAff0(arm_sys, tc);
+ aff.aff1 = getAff1(arm_sys, tc);
+ aff.aff2 = getAff2(arm_sys, tc);
+ return aff;
}
bool
diff --git a/src/arch/arm/utility.hh b/src/arch/arm/utility.hh
index 0e5f3bb..00b0acf 100644
--- a/src/arch/arm/utility.hh
+++ b/src/arch/arm/utility.hh
@@ -223,7 +223,7 @@
RegVal getMPIDR(ArmSystem *arm_sys, ThreadContext *tc);
/** Retrieves MPIDR_EL1.{Aff2,Aff1,Aff0} affinity numbers */
-RegVal getAffinity(ArmSystem *arm_sys, ThreadContext *tc);
+Affinity getAffinity(ArmSystem *arm_sys, ThreadContext *tc);
static inline uint32_t
mcrMrcIssBuild(bool isRead, uint32_t crm, IntRegIndex rt, uint32_t crn,
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55705
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I42461de26886b1ba9e4db5b23a9fb970d3a1efd7
Gerrit-Change-Number: 55705
Gerrit-PatchSet: 8
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
