Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/56188 )
Change subject: scons: Remove a blanket USE_KVM disable check from
SConstruct.
......................................................................
scons: Remove a blanket USE_KVM disable check from SConstruct.
Whether to honor the USE_KVM setting can be handled in a more targeted
way down at individual consumers. They will know what ISA the host needs
to be for their particular model to make sense, where the SConstruct has
to enable or disable it for the entire build of gem5.
Change-Id: I9e82e232203834f6fe56d0ce5cf696809a0970bc
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/56188
Maintainer: Gabe Black <[email protected]>
Reviewed-by: Bobby Bruce <[email protected]>
Tested-by: kokoro <[email protected]>
---
M SConstruct
1 file changed, 18 insertions(+), 3 deletions(-)
Approvals:
Bobby Bruce: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/SConstruct b/SConstruct
index 6cdffe5..93b421e 100755
--- a/SConstruct
+++ b/SConstruct
@@ -733,9 +733,6 @@
if env['USE_EFENCE']:
env.Append(LIBS=['efence'])
- if env['KVM_ISA'] != env['TARGET_ISA']:
- env['USE_KVM'] = False
-
# Save sticky variable settings back to current variables file
sticky_vars.Save(current_vars_file, env)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56188
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9e82e232203834f6fe56d0ce5cf696809a0970bc
Gerrit-Change-Number: 56188
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby Bruce <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
