Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55744 )
Change subject: tests: Add x86 mutlicore boot tests for timing CPUs
......................................................................
tests: Add x86 mutlicore boot tests for timing CPUs
Due to a spin lock error affecting multicore timing cores,
https://gem5.atlassian.net/browse/GEM5-1105, gem5 only supported
single-core timing setups. As this has now been fixed, we support it.
This patch expands the boot tests to include tests for multicore timing
CPU systems.
Change-Id: I89b7f1bed077373dae5e9b8eb6818129da915fee
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55744
Reviewed-by: Austin Harris <m...@austin-harris.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
Tested-by: kokoro <noreply+kok...@google.com>
---
M tests/gem5/x86-boot-tests/test_linux_boot.py
1 file changed, 45 insertions(+), 6 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Austin Harris: Looks good to me, but someone else must approve
Bobby Bruce: Looks good to me, approved
kokoro: Regressions pass
diff --git a/tests/gem5/x86-boot-tests/test_linux_boot.py
b/tests/gem5/x86-boot-tests/test_linux_boot.py
index 77d1c0d..4b66541 100644
--- a/tests/gem5/x86-boot-tests/test_linux_boot.py
+++ b/tests/gem5/x86-boot-tests/test_linux_boot.py
@@ -126,6 +126,15 @@
)
test_boot(
+ cpu="timing",
+ num_cpus=8,
+ mem_system="classic",
+ memory_class="SingleChannelDDR3_2133",
+ to_tick=10000000000,
+ length=constants.quick_tag,
+)
+
+test_boot(
cpu="atomic",
num_cpus=4,
mem_system="classic",
@@ -173,6 +182,15 @@
)
test_boot(
+ cpu="timing",
+ num_cpus=4,
+ mem_system="classic",
+ memory_class="DualChannelDDR3_2133",
+ boot_type="init",
+ length=constants.long_tag,
+)
+
+test_boot(
cpu="atomic",
num_cpus=4,
mem_system="classic",
@@ -224,15 +242,15 @@
},
"timing": {
1: True,
- 2: False, # Timeout
- 4: False, # Timeout
- 8: False, # Timeout
+ 2: True,
+ 4: True,
+ 8: True,
},
"o3": {
1: False, # Timeout
- 2: False, # Not Supported
- 4: False, # Not Supported
- 8: False, # Not Supported
+ 2: False, # Timeout
+ 4: False, # Timeout
+ 8: False, # Timeout
},
},
"mi_example": {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55744
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I89b7f1bed077373dae5e9b8eb6818129da915fee
Gerrit-Change-Number: 55744
Gerrit-PatchSet: 3
Gerrit-Owner: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Austin Harris <m...@austin-harris.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
