Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/57010 )
Change subject: arch-x86: Eliminate the CPUID internal addr prefix.
......................................................................
arch-x86: Eliminate the CPUID internal addr prefix.
This was not implemented and not used. Since CPUID is implemented using
a different mechanism, this will never be used and so can be deleted.
Change-Id: I75c3eb7ebe290c972d4dc6a4827172b136387431
---
M src/arch/amdgpu/common/tlb.cc
M src/arch/x86/tlb.cc
M src/arch/x86/x86_traits.hh
3 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/src/arch/amdgpu/common/tlb.cc b/src/arch/amdgpu/common/tlb.cc
index f0f806a..0a00185 100644
--- a/src/arch/amdgpu/common/tlb.cc
+++ b/src/arch/amdgpu/common/tlb.cc
@@ -303,9 +303,7 @@
Addr vaddr = req->getVaddr();
Addr prefix = (vaddr >> 3) & IntAddrPrefixMask;
- if (prefix == IntAddrPrefixCPUID) {
- panic("CPUID memory space not yet implemented!\n");
- } else if (prefix == IntAddrPrefixMSR) {
+ if (prefix == IntAddrPrefixMSR) {
vaddr = (vaddr >> 3) & ~IntAddrPrefixMask;
MiscRegIndex regNum;
diff --git a/src/arch/x86/tlb.cc b/src/arch/x86/tlb.cc
index 6f5d51d..024f880 100644
--- a/src/arch/x86/tlb.cc
+++ b/src/arch/x86/tlb.cc
@@ -200,9 +200,7 @@
DPRINTF(TLB, "Addresses references internal memory.\n");
Addr vaddr = req->getVaddr();
Addr prefix = (vaddr >> 3) & IntAddrPrefixMask;
- if (prefix == IntAddrPrefixCPUID) {
- panic("CPUID memory space not yet implemented!\n");
- } else if (prefix == IntAddrPrefixMSR) {
+ if (prefix == IntAddrPrefixMSR) {
vaddr = (vaddr >> 3) & ~IntAddrPrefixMask;
MiscRegIndex regNum;
diff --git a/src/arch/x86/x86_traits.hh b/src/arch/x86/x86_traits.hh
index e4a6392..71c4c87 100644
--- a/src/arch/x86/x86_traits.hh
+++ b/src/arch/x86/x86_traits.hh
@@ -60,7 +60,6 @@
const int NumSysSegments = 4;
const Addr IntAddrPrefixMask = 0xffffffff00000000ULL;
- const Addr IntAddrPrefixCPUID = 0x100000000ULL;
const Addr IntAddrPrefixMSR = 0x200000000ULL;
const Addr IntAddrPrefixIO = 0x300000000ULL;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57010
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I75c3eb7ebe290c972d4dc6a4827172b136387431
Gerrit-Change-Number: 57010
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
