Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55624 )
(
11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: arch-x86: Don't load past the end of the far pointer in
real mode jmp.
......................................................................
arch-x86: Don't load past the end of the far pointer in real mode jmp.
When loading the segment selector from the far pointer, only load two
bytes to avoid unnecessarily going beyond a boundary where accesses may
not be allowed.
Change-Id: I4fc31e3f87815a19232390966c25d156be6a7e92
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55624
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git
a/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
b/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
index c747c96..77c6968 100644
--- a/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
+++ b/src/arch/x86/isa/insts/general_purpose/control_transfer/jump.py
@@ -151,7 +151,7 @@
.control_indirect
lea t1, seg, sib, disp, dataSize=asz
- ld t2, seg, [1, t0, t1], dsz
+ ld t2, seg, [1, t0, t1], dsz, dataSize=2
ld t1, seg, [1, t0, t1]
zexti t3, t2, 15, dataSize=8
slli t3, t3, 4, dataSize=8
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55624
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4fc31e3f87815a19232390966c25d156be6a7e92
Gerrit-Change-Number: 55624
Gerrit-PatchSet: 13
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Matt Sinclair <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
