Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/57229 )
Change subject: sim: Avoid -Werror=unused-variable in bufval unittests
......................................................................
sim: Avoid -Werror=unused-variable in bufval unittests
Some compilers (e.g. gcc-7.5) throw a warning/error when a structured
binding variable is not used.
Change-Id: Ib5090508d135e4a72c39f18b316c76674c3bd8f3
Signed-off-by: Giacomo Travaglini <giacomo.travagl...@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/57229
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Maintainer: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/sim/bufval.test.cc
1 file changed, 18 insertions(+), 2 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/bufval.test.cc b/src/sim/bufval.test.cc
index 91c074a..e5a0635 100644
--- a/src/sim/bufval.test.cc
+++ b/src/sim/bufval.test.cc
@@ -40,8 +40,7 @@
bool
pairFail(const std::pair<First, bool> &p)
{
- auto &[first, success] = p;
- return !success;
+ return !p.second;
}
bool
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57229
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib5090508d135e4a72c39f18b316c76674c3bd8f3
Gerrit-Change-Number: 57229
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
