Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/57949 )
Change subject: arch-vega: Replace deprecated Stats namespace recently
reintroduced.
......................................................................
arch-vega: Replace deprecated Stats namespace recently reintroduced.
The deprecated "Stats" namespace was recently reintroduced to the vega
TLB code. Replace it with the new statistics namespace.
Change-Id: Ie5daf288176ce7e8aadd27b84a70baf4cbc72dff
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/57949
Reviewed-by: Matthew Poremba <matthew.pore...@amd.com>
Maintainer: Matthew Poremba <matthew.pore...@amd.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/amdgpu/vega/tlb.hh
M src/arch/amdgpu/vega/tlb_coalescer.hh
2 files changed, 37 insertions(+), 21 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/amdgpu/vega/tlb.hh b/src/arch/amdgpu/vega/tlb.hh
index 5ac108a..c38f591 100644
--- a/src/arch/amdgpu/vega/tlb.hh
+++ b/src/arch/amdgpu/vega/tlb.hh
@@ -158,31 +158,31 @@
{
VegaTLBStats(statistics::Group *parent);
- Stats::Scalar maxDownstreamReached;
- Stats::Scalar outstandingReqsMax;
+ statistics::Scalar maxDownstreamReached;
+ statistics::Scalar outstandingReqsMax;
// local_stats are as seen from the TLB
// without taking into account coalescing
- Stats::Scalar localNumTLBAccesses;
- Stats::Scalar localNumTLBHits;
- Stats::Scalar localNumTLBMisses;
- Stats::Formula localTLBMissRate;
+ statistics::Scalar localNumTLBAccesses;
+ statistics::Scalar localNumTLBHits;
+ statistics::Scalar localNumTLBMisses;
+ statistics::Formula localTLBMissRate;
// global_stats are as seen from the
// CU's perspective taking into account
// all coalesced requests.
- Stats::Scalar globalNumTLBAccesses;
- Stats::Scalar globalNumTLBHits;
- Stats::Scalar globalNumTLBMisses;
- Stats::Formula globalTLBMissRate;
+ statistics::Scalar globalNumTLBAccesses;
+ statistics::Scalar globalNumTLBHits;
+ statistics::Scalar globalNumTLBMisses;
+ statistics::Formula globalTLBMissRate;
// from the CU perspective (global)
- Stats::Scalar accessCycles;
- Stats::Scalar pageTableCycles;
+ statistics::Scalar accessCycles;
+ statistics::Scalar pageTableCycles;
// from the perspective of this TLB
- Stats::Scalar localCycles;
- Stats::Formula localLatency;
+ statistics::Scalar localCycles;
+ statistics::Formula localLatency;
} stats;
diff --git a/src/arch/amdgpu/vega/tlb_coalescer.hh
b/src/arch/amdgpu/vega/tlb_coalescer.hh
index 127c159..da73b2e 100644
--- a/src/arch/amdgpu/vega/tlb_coalescer.hh
+++ b/src/arch/amdgpu/vega/tlb_coalescer.hh
@@ -110,24 +110,24 @@
CoalescingTable issuedTranslationsTable;
// number of packets the coalescer receives
- Stats::Scalar uncoalescedAccesses;
+ statistics::Scalar uncoalescedAccesses;
// number packets the coalescer send to the TLB
- Stats::Scalar coalescedAccesses;
+ statistics::Scalar coalescedAccesses;
// Number of cycles the coalesced requests spend waiting in
// coalescerFIFO. For each packet the coalescer receives we take into
// account the number of all uncoalesced requests this pkt "represents"
- Stats::Scalar queuingCycles;
+ statistics::Scalar queuingCycles;
// On average how much time a request from the
// uncoalescedAccesses that reaches the TLB
// spends waiting?
- Stats::Scalar localqueuingCycles;
- Stats::Scalar localCycles;
+ statistics::Scalar localqueuingCycles;
+ statistics::Scalar localCycles;
// localqueuingCycles/uncoalescedAccesses
- Stats::Formula localLatency;
+ statistics::Formula localLatency;
// latency of a request to be completed
- Stats::Formula latency;
+ statistics::Formula latency;
bool canCoalesce(PacketPtr pkt1, PacketPtr pkt2);
void updatePhysAddresses(PacketPtr pkt);
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57949
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie5daf288176ce7e8aadd27b84a70baf4cbc72dff
Gerrit-Change-Number: 57949
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
