Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/58171 )
Change subject: scons: Remove the default-default build target.
......................................................................
scons: Remove the default-default build target.
In gem5, there are many equally valid and equally useful top level
targets which the user might want. It no longer makes sense to
arbitrarily pick one to be the default target. It makes sense to force
the user to actually specify what they want, instead of assuming it
must be the ARM debug binary.
There is currently an M5_DEFAULT_BINARY environment variable which
will change what the default binary is, if set. This change leaves
that in place, but removes the default-default, or in other words the
default that is used if M5_DEFAULT_BINARY is not set.
This way if the user knows what default they want, they can specify it
locally in their environment and avoid having to type it over and over
again, but we're not making an arbitrary choice at a more global level
without the context to know what actually makes sense.
Change-Id: I886adb1289b9879d53387250f950909a4809ed8b
---
M SConstruct
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/SConstruct b/SConstruct
index a15c304..bba3c98 100755
--- a/SConstruct
+++ b/SConstruct
@@ -172,7 +172,9 @@
error("No C++ compiler installed (package g++ on Ubuntu and RedHat)")
# Find default configuration & binary.
-Default(environ.get('M5_DEFAULT_BINARY', 'build/ARM/gem5.debug'))
+default_target = environ.get('M5_DEFAULT_BINARY', None)
+if default_target:
+ Default(default_target)
defconfig_dir = Dir('#defconfig')
defconfigs = list([f for f in os.listdir(defconfig_dir.abspath) if
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58171
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I886adb1289b9879d53387250f950909a4809ed8b
Gerrit-Change-Number: 58171
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
