Daecheol You has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/58412 )
Change subject: mem-ruby: fix the condition for stale WriteCleanFull
......................................................................
mem-ruby: fix the condition for stale WriteCleanFull
WriteCleanFull can be requested for the cache line in SD state (e.g.
Local eviction of a cache line in SD_RSC state). In this case, the
requestor is the owner of the cache line,
but it doesn't have it with exclusive right.
Thus, 'ownerIsExcl == false' should be removed from the stale condition.
Change-Id: I4d34021ac31b2e8600c24689a03a3b8fa18aa1f7
---
M src/mem/ruby/protocol/chi/CHI-cache-ports.sm
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/mem/ruby/protocol/chi/CHI-cache-ports.sm
b/src/mem/ruby/protocol/chi/CHI-cache-ports.sm
index d9cb0f1..992f685 100644
--- a/src/mem/ruby/protocol/chi/CHI-cache-ports.sm
+++ b/src/mem/ruby/protocol/chi/CHI-cache-ports.sm
@@ -276,7 +276,7 @@
}
} else if (in_msg.type == CHIRequestType:WriteCleanFull) {
if (is_invalid(dir_entry) || (dir_entry.ownerExists == false) ||
- (dir_entry.ownerIsExcl == false) || (dir_entry.owner !=
in_msg.requestor)) {
+ (dir_entry.owner != in_msg.requestor)) {
trigger(Event:WriteCleanFull_Stale, in_msg.addr, cache_entry,
tbe);
}
} else if (in_msg.type == CHIRequestType:Evict) {
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/58412
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I4d34021ac31b2e8600c24689a03a3b8fa18aa1f7
Gerrit-Change-Number: 58412
Gerrit-PatchSet: 1
Gerrit-Owner: Daecheol You <daecheol....@samsung.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
