Hanhwi Jang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67231?usp=email )
Change subject: cpu-o3: Resolve the skid buffer overflow issue at decode
stage
......................................................................
cpu-o3: Resolve the skid buffer overflow issue at decode stage
When decode width is larger than fetch width, the skid buffer
overflow happens at decode stage. The decode stage assumes
that fetch stage sends instructions as many as the fetch width,
but it sends them at decode width rate.
This patch makes the decode stage set its skid buffer size
according to the decode width.
Change-Id: I90ee43d16c59a4c9305c77bbfad7e4cdb2b9cffa
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67231
Maintainer: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Hanhwi Jang <jang.han...@gmail.com>
Reviewed-by: Tom Rollet <tom.rol...@huawei.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/cpu/o3/decode.cc
1 file changed, 24 insertions(+), 1 deletion(-)
Approvals:
Tom Rollet: Looks good to me, but someone else must approve
Jason Lowe-Power: Looks good to me, but someone else must approve; Looks
good to me, approved
kokoro: Regressions pass
Hanhwi Jang: Looks good to me, approved
diff --git a/src/cpu/o3/decode.cc b/src/cpu/o3/decode.cc
index 9555e32..ac728a2 100644
--- a/src/cpu/o3/decode.cc
+++ b/src/cpu/o3/decode.cc
@@ -77,7 +77,7 @@
decodeWidth, static_cast<int>(MaxWidth));
// @todo: Make into a parameter
- skidBufferMax = (fetchToDecodeDelay + 1) * params.fetchWidth;
+ skidBufferMax = (fetchToDecodeDelay + 1) * params.decodeWidth;
for (int tid = 0; tid < MaxThreads; tid++) {
stalls[tid] = {false};
decodeStatus[tid] = Idle;
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67231?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I90ee43d16c59a4c9305c77bbfad7e4cdb2b9cffa
Gerrit-Change-Number: 67231
Gerrit-PatchSet: 2
Gerrit-Owner: Hanhwi Jang <jang.han...@gmail.com>
Gerrit-Reviewer: Hanhwi Jang <jang.han...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Tom Rollet <tom.rol...@huawei.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
