Matt Sinclair has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67200?usp=email )
Change subject: mem-ruby: fix TCP spacing/spelling
......................................................................
mem-ruby: fix TCP spacing/spelling
Change-Id: I3fd9009592c8716a3da19dcdccf68f16af6522ef
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67200
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/mem/ruby/protocol/GPU_VIPER-TCP.sm
1 file changed, 19 insertions(+), 6 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/mem/ruby/protocol/GPU_VIPER-TCP.sm
b/src/mem/ruby/protocol/GPU_VIPER-TCP.sm
index 14bdcec..6a977c4 100644
--- a/src/mem/ruby/protocol/GPU_VIPER-TCP.sm
+++ b/src/mem/ruby/protocol/GPU_VIPER-TCP.sm
@@ -261,7 +261,7 @@
// If L1 is disabled or requests have GLC or SLC flag set,
// then, the requests should not cache in the L1. The
response
// from L2/global memory should bypass the cache
- trigger(Event:Bypass, in_msg.addr, cache_entry, tbe);
+ trigger(Event:Bypass, in_msg.addr, cache_entry, tbe);
} else {
if (is_valid(cache_entry) || L1cache.cacheAvail(in_msg.addr)) {
trigger(Event:TCC_Ack, in_msg.addr, cache_entry, tbe);
@@ -288,7 +288,7 @@
DPRINTF(RubySlicc, "%s\n", in_msg);
if (in_msg.Type == RubyRequestType:LD) {
if ((in_msg.isGLCSet || in_msg.isSLCSet) &&
is_valid(cache_entry)) {
- // Read rquests with GLC or SLC bit set should not cache in
the L1.
+ // Read requests with GLC or SLC bit set should not cache in
the L1.
// They need to bypass the L1 and go to the L2. If an entry
exists
// in the L1, it needs to be evicted
trigger(Event:LoadBypassEvict, in_msg.LineAddress,
cache_entry, tbe);
@@ -609,15 +609,15 @@
p_popMandatoryQueue;
}
-// Transition to be called when a load request with GLC or SLC flag set
arrives
-// at L1. This transition invalidates any existing entry and forwards the
-// request to L2.
+ // Transition to be called when a load request with GLC or SLC flag set
arrives
+ // at L1. This transition invalidates any existing entry and forwards the
+ // request to L2.
transition(V, LoadBypassEvict, I) {TagArrayRead, TagArrayWrite} {
uu_profileDataMiss;
ic_invCache;
n_issueRdBlk;
p_popMandatoryQueue;
-}
+ }
transition({V, I}, Atomic, A) {TagArrayRead, TagArrayWrite} {
t_allocateTBE;
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67200?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3fd9009592c8716a3da19dcdccf68f16af6522ef
Gerrit-Change-Number: 67200
Gerrit-PatchSet: 2
Gerrit-Owner: Matt Sinclair <mattdsinclair.w...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <ja...@lowepower.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Matt Sinclair <mattdsincl...@gmail.com>
Gerrit-Reviewer: Matthew Poremba <matthew.pore...@amd.com>
Gerrit-Reviewer: VISHNU RAMADAS <vrama...@wisc.edu>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
