Melissa Jost has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/65651?usp=email )

Change subject: tests: Update testing documentation
......................................................................

tests: Update testing documentation

This edits the documentation regarding the usage of the --isa
tag, as this has fallen out of date in regards to the new
'ALL' isa.

Change-Id: I3b672ac2c03dd109bba458db688af05ed4135a91
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65651
Tested-by: kokoro <noreply+kok...@google.com>
Reviewed-by: Bobby Bruce <bbr...@ucdavis.edu>
Maintainer: Bobby Bruce <bbr...@ucdavis.edu>
---
M TESTING.md
M tests/gem5/fixture.py
2 files changed, 30 insertions(+), 6 deletions(-)

Approvals:
  kokoro: Regressions pass
  Bobby Bruce: Looks good to me, approved; Looks good to me, approved




diff --git a/TESTING.md b/TESTING.md
index 2273e31..146aeac 100644
--- a/TESTING.md
+++ b/TESTING.md
@@ -86,10 +86,10 @@
 ./main.py run --variant opt
 ```

-Or, if you want to just run X86 tests with the `gem5.opt` binary:
+Or, if you want to just run quick tests with the `gem5.opt` binary:

 ```shell
-./main.py run --length quick --variant opt --isa X86
+./main.py run --length quick --variant opt
 ```


@@ -102,6 +102,14 @@
 The output is split into tag *types* (e.g., isa, variant, length) and the
 tags for each type are listed after the type name.

+Note that when using the isa tag type, tests were traditionally sorted based
+on what compilation it required. However, as tests have switched to all be
+compiled under the ALL compilation, which includes all ISAs so one doesn't
+need to compile each one individually, using the isa tag for ISAs other than
+ALL has become a less optimal way of searching for tests.  It would instead
+be better to run subsets of tests based on their directories, as described
+above.
+
You can specify "or" between tags within the same type by using the tag flag multiple times. For instance, to run everything that is tagged "opt" or "fast"
 use
@@ -112,10 +120,10 @@

You can also specify "and" between different types of tags by specifying more than one type on the command line. For instance, this will only run tests with
-both the "X86" and "opt" tags.
+both the "ALL" and "opt" tags.

 ```shell
-./main.py run --isa X86 --variant opt
+./main.py run --isa All --variant opt
 ```

 ## Running tests in batch
diff --git a/tests/gem5/fixture.py b/tests/gem5/fixture.py
index c8bc79f..6f5dd61 100644
--- a/tests/gem5/fixture.py
+++ b/tests/gem5/fixture.py
@@ -174,8 +174,7 @@
             )
             log.test_log.message("%s" % (", ".join(self.targets)))
             log.test_log.message(
-                "You may want to run with only a single ISA"
-                "(--isa=), use --skip-build, or use 'rerun'."
+                "You may want to use --skip-build, or use 'rerun'."
             )

         command.extend(self.targets)

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/65651?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I3b672ac2c03dd109bba458db688af05ed4135a91
Gerrit-Change-Number: 65651
Gerrit-PatchSet: 3
Gerrit-Owner: Melissa Jost <melissakj...@gmail.com>
Gerrit-Reviewer: Bobby Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Boris Shingarov <shinga...@labware.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Melissa Jost <melissakj...@gmail.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

Reply via email to