Wei-Han Chen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: dev: Warn when resp packet is error in dma port
......................................................................
dev: Warn when resp packet is error in dma port
This CL adds a warning when the response packet is error.
Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/71778
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Maintainer: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Yu-hsin Wang <yuhsi...@google.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/dev/dma_device.cc
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yu-hsin Wang: Looks good to me, but someone else must approve
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/dma_device.cc b/src/dev/dma_device.cc
index 24e931e..70a74ee 100644
--- a/src/dev/dma_device.cc
+++ b/src/dev/dma_device.cc
@@ -68,6 +68,7 @@
{
// Should always see a response with a sender state.
assert(pkt->isResponse());
+ warn_if(pkt->isError(), "Response pkt error.");
// Get the DMA sender state.
auto *state = dynamic_cast<DmaReqState*>(pkt->senderState);
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/71778?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I8e94dc2b85cd1753a4d6265cfda3cd5d6325f425
Gerrit-Change-Number: 71778
Gerrit-PatchSet: 3
Gerrit-Owner: Wei-Han Chen <weihanc...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Wei-Han Chen <weihanc...@google.com>
Gerrit-Reviewer: Yu-hsin Wang <yuhsi...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-CC: kokoro <noreply+kok...@google.com>
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
