One unknown is whether or not to uncomment the call to disconnectFromPeer() in Port::setPort(). Conceptually it should be there, and I believe having it commented out was the source of the memory leak that was giving Ali trouble. If Ali's fix got rid of all the places where we have N:1 functional port connections then we should uncomment it. If not, then we can leave it commented out, since I believe Ali's fix did get rid of all the places where we dynamically allocate ports like they're going out of style, which means not reclaiming a few won't be such a big deal. (Or better yet, we should find those other N:1 cases and fix them too.)
Steve On Tue, Jul 8, 2008 at 6:52 AM, Steve Reinhardt <[EMAIL PROTECTED]> wrote: > I think someone just needs to reapply it and test it. > > Steve > > On Mon, Jul 7, 2008 at 9:11 PM, nathan binkert <[EMAIL PROTECTED]> wrote: >> So, you committed that fix to the dynamic creating of virtual ports. >> What's the status of this diff? _______________________________________________ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
