THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. A new Flyspray task has been opened. Details are below.
User who did this: - Steve Reinhardt (stever) Attached to Project - M5 Bugs Summary - Clean up VirtualPort/TranslatingPort Task Type - Minor Enhancement Category - Memory System Status - New Assigned To - Operating System - All Severity - Low Priority - Normal Reported Version - 2.0beta5 Due in Version - Due Date - Undecided Details - We currently have two different port objects that basically do the same thing (embed virt->phys translation in a port interface): VirtualPort (in mem/vport.*) and TranslatingPort (in mem/translating_port.*). Although the only real difference is that the former is for FS mode and the latter is for SE mode, they currently have different interfaces, different capabilities, and a noticeable fraction of redundant code. These two classes should be unified into a single implementation with a single interface, perhaps with a template parameter that specifies the low-level translation call to use. Some particular issues: - The CopyIn/CopyOut functions in vport.* should be methods on some object (probably ThreadContext) and not global functions. They should of course also be renamed to follow the style guidelines. - TranslatingPort provides read/writeString and read/writeBlob functions, but the equivalent copyIn/copyOut functions are implemented on BaseBufferArg in syscall_emul.hh as thin wrappers around read/writeBlob. If the FS mode functions are moved to ThreadContext then these SE-mode equivalents should be moved there also (note that the SE functions are always called with tc->getMemPort() as their argument, so it makes sense to move it there). More information can be found at the following URL: http://www.m5sim.org/flyspray/task/321 You are receiving this message because you have requested it from the Flyspray bugtracking system. You can be removed from future notifications by visiting the URL shown above. _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
