> This is a simple patch to fix FlySpray issue #315. We don't panic if a
> parameter without a default value isn't set which is a problem if the
> reason a default isn't set is that the user really needs to set one.
> I'm sending this mostly for Nate to say he is fine with doing it this
> way.
Are those the only parameters missing meaningful defaults?

>> diff --git a/src/cpu/BaseCPU.py b/src/cpu/BaseCPU.py

>> -    checker = Param.BaseCPU("checker CPU")
>> +    checker = Param.BaseCPU(NULL, "checker CPU")
This makes sense.

>> -    image_file = Param.String("disk image file")
>> +    image_file = Param.String("", "disk image file")
Really?  You don't have to set an image_file?

>> +                print >>sys.stderr, "fatal: %s.%s without default
>> or user set value" \
>> +                        % (self.path(), param)
>> +                sys.exit(1)
I added a fatal() call in python.  It's m5.fatal()
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to