On Jan 30, 2009, at 1:38 AM, nathan binkert wrote:
>> This is a simple patch to fix FlySpray issue #315. We don't panic
>> if a
>> parameter without a default value isn't set which is a problem if the
>> reason a default isn't set is that the user really needs to set one.
>> I'm sending this mostly for Nate to say he is fine with doing it this
>> way.
> Are those the only parameters missing meaningful defaults?
Yea.
>
>
>>> diff --git a/src/cpu/BaseCPU.py b/src/cpu/BaseCPU.py
>
>>> - checker = Param.BaseCPU("checker CPU")
>>> + checker = Param.BaseCPU(NULL, "checker CPU")
> This makes sense.
>
>>> - image_file = Param.String("disk image file")
>>> + image_file = Param.String("", "disk image file")
> Really? You don't have to set an image_file?
You do for RawDiskImage, but you don't for CowDiskImage which inherits
from it. If you don't set it and use it in a RawDiskImage you'll get a
fatal() now.
Ali
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
