I got rid of the argument arrays because x86 doesn't always use the same registers to get a particular argument depending on if you're in a 32 bit or 64 bit binary. Since the array doesn't exist any more, I put in a substitute in the few places it had been used directly.
Gabe Quoting Korey Sewell <[email protected]>: > Hey Gabe, > why did we make the switch from ArgumentReg array to argument names? > Just wondering. > > On Fri, Feb 27, 2009 at 12:37 PM, Gabe Black <[email protected]> wrote: >> changeset 4270e0502e5e in /z/repo/encumbered >> details: http://repo.m5sim.org/encumbered?cmd=changeset;node=4270e0502e5e >> summary: CPU: Stop using the ArgumentReg array to get argument indexes. >> >> diffstat: >> >> 1 file changed, 5 insertions(+), 5 deletions(-) >> eio/alpha_exo.h | 10 +++++----- >> >> diffs (26 lines): >> >> diff -r 324547c99895 -r 4270e0502e5e eio/alpha_exo.h >> --- a/eio/alpha_exo.h Wed Nov 05 16:21:42 2008 -0500 >> +++ b/eio/alpha_exo.h Fri Feb 27 09:30:54 2009 -0800 >> @@ -124,17 +124,17 @@ >> /* non-zero if system call is an exit() */ >> #define OSF_SYS_exit 1 >> #define MD_EXIT_SYSCALL(XC) \ >> - ((XC)->readIntReg(AlphaISA::ReturnValueReg) == OSF_SYS_exit) >> + ((XC)->readIntReg(AlphaISA::SyscallNumReg) == OSF_SYS_exit) >> >> /* non-zero if system call is a write to stdout/stderr */ >> #define OSF_SYS_write 4 >> #define MD_OUTPUT_SYSCALL(XC) \ >> - ((XC)->readIntReg(AlphaISA::ReturnValueReg) == OSF_SYS_write >> \ >> - && ((XC)->readIntReg(AlphaISA::ArgumentReg[0]) == /* stdout */1 >> \ >> - || (XC)->readIntReg(AlphaISA::ArgumentReg[0]) == /* stderr */2)) >> + ((XC)->readIntReg(AlphaISA::SyscallNumReg) == OSF_SYS_write >> \ >> + && ((XC)->readIntReg(AlphaISA::FirstArgumentReg) == /* stdout >> */1 \ >> + || (XC)->readIntReg(AlphaISA::FirstArgumentReg) == /* stderr */2)) >> >> /* returns stream of an output system call, translated to host */ >> -#define MD_STREAM_FILENO(XC) ((XC)->readIntReg(AlphaISA::ArgumentReg[0])) >> +#define MD_STREAM_FILENO(XC) ((XC)->readIntReg(AlphaISA::FirstArgumentReg)) >> >> /* >> * configure the EXO package >> _______________________________________________ >> m5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/listinfo/m5-dev >> > > > > -- > ---------- > Korey L Sewell > Graduate Student - PhD Candidate > Computer Science & Engineering > University of Michigan > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
