>
>> -X86LinuxProcess::X86LinuxProcess(LiveProcessParams * params,
>> +X86_64LinuxProcess::X86_64LinuxProcess(LiveProcessParams * params,
>> ObjectFile *objFile)
>> - : X86LiveProcess(params, objFile),
>> - Num_Syscall_Descs(273)
>> + : X86LinuxProcess(params, objFile, syscallDescs, 273)
>> {}
>>
> [...]
>
>> +I386LinuxProcess::I386LinuxProcess(LiveProcessParams * params,
>> + ObjectFile *objFile)
>> + : X86LinuxProcess(params, objFile, syscallDescs, 324)
>> +{}
>>
>
> Why the magic numbers (273, 324)? I see that the automatic
> calculation in other ISAs isn't feasible here because you've got the
> syscalls in a separate file... but I don't see the benefit in
> splitting them out, since now process.cc only has about a half dozen
> lines of actual code in it, particularly when the price you pay is
> having to use arbitrary constants like this.
>
The syscalls are split out because I followed the same structure I had
for SPARC. They're split out for SPARC because I was trying to
reorganize the code so it was easier to navigate. I think it's easier to
read the code with the syscall tables split out into a separate file,
but I don't like the magic numbers either and didn't at the time way
back when for SPARC. I'll see what I can do about it at some point. I
could probably do the computation in the syscalls.cc file.
Gabe
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
