On Sat, Feb 28, 2009 at 5:05 PM, Gabe Black <[email protected]> wrote:
> The syscalls are split out because I followed the same structure I had
> for SPARC. They're split out for SPARC because I was trying to
> reorganize the code so it was easier to navigate. I think it's easier to
> read the code with the syscall tables split out into a separate file,
> but I don't like the magic numbers either and didn't at the time way
> back when for SPARC. I'll see what I can do about it at some point. I
> could probably do the computation in the syscalls.cc file.

OK... it didn't seem like you to have random constants in your code.
Personally as I said since I can count the meaningful lines of code in
process.cc on my fingers I'd just leave it all in one file, but if
you're dead set on splitting the syscalls out, I won't complain as
long as you fix the magic number thing.

Steve
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to