Korey Sewell wrote: > > <text below> > > On Sat, Jul 25, 2009 at 1:00 AM, Gabe Black <[email protected] > <mailto:[email protected]>> wrote: > > Right, that part makes sense. The thing I'm asking about is the > line you > added here > > > CPUClass.clock = '2GHz' > +CPUClass.numThreads = len(workloads) > > where it looks to me like you're scaling up the number of threads > so the > workloads will fit. What I'm saying is that if somebody has too many > workloads, that's probably wrong and they should hit the fatal you've > added rather than accommodating it. I could be misinterpreting the > code > since I'm not seeing it in context. > > > Oh, I see. I'm not sure what the right answer is there then. > > I thought it would be nice to have the se.py file figure out what type > of SMT CPU you're using and just set the parameter. > > However, the way you're saying (I think) is the users have to manually > change the se.py file (or create a new one) in order to set the > numThreads to the appropriate amount. > > I could see it that way too if people think that's best. > > -- > - Korey > ------------------------------------------------------------------------ > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev >
We could also add a command line argument to the script. One thing to note is that I think se.py is supposed to just be an example. I have the impression it's often used exactly as is though, so that may not be a valid way to look at it. Gabe _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
