Comments inline
> diff -r 8f73bf7c3c5e -r 5d3a90f0ef4c src/mem/protocol/SConscript
> --- a/src/mem/protocol/SConscript Sat Dec 12 14:37:14 2009 -0800
> +++ b/src/mem/protocol/SConscript Sat Dec 12 14:37:14 2009 -0800
> +for f in nodes:
> + s = str(f)
> + if str(s).endswith('.cc'):
> + Source(f)
> + elif str(s).endswith('.py'):
> + SimObject(f)
> +
You don't need the str(s) since s is already a string.
> diff -r 8f73bf7c3c5e -r 5d3a90f0ef4c src/mem/slicc/parser.py
> --- a/src/mem/slicc/parser.py Sat Dec 12 14:37:14 2009 -0800
> +++ b/src/mem/slicc/parser.py Sat Dec 12 14:37:14 2009 -0800
> @@ -418,6 +416,10 @@
> "param : type ident"
> p[0] = ast.FormalParamAST(self, p[1], p[2])
>
> + def p_param__default(self, p):
> + "param : type ident '=' NUMBER"
> + p[0] = ast.FormalParamAST(self, p[1], p[2], p[4])
> +
> # Idents and lists
> def p_idents__braced(self, p):
> "idents : '{' identx '}'"
This syntax is getting odd. I'm not sure if it's worthing changing at
this point, but organic growth of a language can make it look ugly
over time.
_______________________________________________
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
