>> - You have some more random whitespace changes in there. >> - You seem to have made some changes to code that was commented out. >> Can we just remove that code? >> - Is SparseMemory a Ruby specific thing, or could it be moved to src/mem? >> - Please use M5 style (4 space indent, function name at the beginning >> of a line, etc.) on new files. > > What about other higher-level Ruby vs. M5 style things, like the '_t' > suffix on types, the 'm_' prefix on member vars, cprintf vs '<<', > etc.? I can sort of see wanting to keep the code in the Ruby dir > consistent, but I hope that we can work toward a globally consistent > style, and writing new code in M5 style would be an important part of > that, I'd think.
I'd actually love to see us move in this direction. My style pass is pretty huge, but I didn't do any of the higher level things (because they're more time consuming). Not that I wouldn't like to see it done. Nate _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
